Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static makes thing impossible to test #5

Open
StephanMoeller opened this issue Dec 2, 2021 · 0 comments
Open

Static makes thing impossible to test #5

StephanMoeller opened this issue Dec 2, 2021 · 0 comments
Labels
v2 To be completed in v2

Comments

@StephanMoeller
Copy link

The loop issue mentioned by kristho can only be tested with real life dns settings proving the problem. This is due to the fact that everything is static. Instead you should remove all static methods will real classes with interfaces. This way there should be a IDnsResolver that will be mockable and the problem with internal loop will be testable without dependencies to the outside world.

@danielsen danielsen added the v2 To be completed in v2 label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 To be completed in v2
Projects
None yet
Development

No branches or pull requests

2 participants