Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package doctest for FreeBSD Ports Collection #581

Closed
dankamongmen opened this issue May 8, 2020 · 5 comments
Closed

Package doctest for FreeBSD Ports Collection #581

dankamongmen opened this issue May 8, 2020 · 5 comments
Assignees
@dankamongmen
Labels
enhancement New feature or request freebsd the freest of bsds, but not very dragonFLY
Milestone
1.5.0

Comments

@dankamongmen
Copy link
Owner

On some platforms, doctest is unavailable. This seems to be the case on FreeBSD, and I've got an active bug out on Fedora support (see #528 ). Given that doctest can be acquired as a single header, we probably ought fetch it in such a case iff USE_NETWORK is ON.

I'm not sure whether FreeBSD Ports are allowed to go grabbing source during the compilation step. If not, this probably isn't worth doing, and we ought just construct our Port using both notcurses and doctest.h as sources (i.e. portsnap or whatever would be grabbing it).
@dankamongmen dankamongmen added enhancement New feature or request freebsd the freest of bsds, but not very dragonFLY labels May 8, 2020
@dankamongmen dankamongmen self-assigned this May 8, 2020
@dankamongmen
Copy link
Owner Author

@yurivict if you have any advice here, I'd appreciate it. Perhaps I've just missed doctest in the Ports Collection, even?

@dankamongmen
Copy link
Owner Author

I think I'd rather just package up doctest for FreeBSD than do this hack.

@dankamongmen dankamongmen reopened this May 9, 2020
@dankamongmen dankamongmen changed the title iff USE_NETWORK is ON, fetch doctest.h when unavailable Package doctest for FreeBSD Ports Collection May 9, 2020
@dankamongmen dankamongmen mentioned this issue May 9, 2020
Closed
@dankamongmen
Copy link
Owner Author

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246653 Port created! Hopefully it will be accepted and we can close this up.

@dankamongmen dankamongmen added this to the 1.5.0 milestone May 22, 2020
@dankamongmen
Copy link
Owner Author

Yuri picked up our Port and committed it. Huzzah!

@yurivict
Copy link

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
enhancement New feature or request freebsd the freest of bsds, but not very dragonFLY
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@dankamongmen @yurivict