Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsteele/buffer support #25

Merged
merged 4 commits into from
Aug 1, 2020
Merged

Conversation

dills122
Copy link
Contributor

@dills122 dills122 commented Aug 1, 2020

Added support for Buffer's as an input type.

New Input Type BufferObject

interface BufferObject {
  ext?: string, // mime type of buffered file
  data: Buffer,
  name?: string // file name for buffered file
}

This will allow for more flexibility in user's inputs.

Additional Upgrades

Another "upgrade" was to switch the test runner over to mocha.

The reasoning behind this was due to some weird intermittent test failures during development that could not be traced back to a bug. Two of the test cases that were popping up a-lot were Should hash remote image and Should handle custom request object and once I migrated the test runner over to mocha I noticed these failures to cease.

@danm danm merged commit 1483cfd into danm:master Aug 1, 2020
@danm
Copy link
Owner

danm commented Aug 1, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants