Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Google Env Var - GOOGLE_LOC #4065

Closed
1 task done
jona7o opened this issue Sep 16, 2024 · 1 comment · Fixed by #4395
Closed
1 task done

Enhancement: Google Env Var - GOOGLE_LOC #4065

jona7o opened this issue Sep 16, 2024 · 1 comment · Fixed by #4395
Assignees
Labels
enhancement New feature or request

Comments

@jona7o
Copy link

jona7o commented Sep 16, 2024

What features would you like to see added?

Add GOOGLE_LOC as location environment variable for Google AI endpoint.

More details

GoogleClient.js defines the location for all calls to us-central1. It would be great if an environment (e.g. GOOGLE_LOC) variable could be added to allow you to switch to a different location for the ai api calls. For example, as a European user, europe-west3 would be a better choice due to GDPR.

const loc = process.env.GOOGLE_LOC || 'us-central1' //current: const loc = 'us-central1';
const publisher = 'google';
const endpointPrefix = 'https://${loc}-aiplatform.googleapis.com';

Which components are impacted by your request?

GoogleClient.js

Pictures

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jona7o jona7o added the enhancement New feature or request label Sep 16, 2024
@jona7o jona7o changed the title Enhancement: Enhancement: Google Env Var - GOOGLE_LOC Sep 16, 2024
@berry-13 berry-13 self-assigned this Sep 19, 2024
@schnaker85
Copy link

can you make sure this is used for the vertex AI calls? see my comment: #3275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants