Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Scene.js, use Fetch API #3

Open
dannycalleri opened this issue Jul 8, 2017 · 0 comments
Open

Refactor Scene.js, use Fetch API #3

dannycalleri opened this issue Jul 8, 2017 · 0 comments

Comments

@dannycalleri
Copy link
Owner

dannycalleri commented Jul 8, 2017

Scene.js is really big. It comes from the first experiment I did.
It could be split in more parts.

For example, the code that sends the HTTP GET request to fetch the 3D model file, could be moved to another file and the Scene can simply take the model's binary data as prop.

Also, the code that sends the HTTP request can be refactored using fetch (https://developer.mozilla.org/en/docs/Web/API/Fetch_API)

This task is linked to #2

@dannycalleri dannycalleri changed the title Refactor Scene.js, use fetch Refactor Scene.js, use Fetch API Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant