Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack connector: improve "workspace" description to avoid broken links #1709

Open
danielnaber opened this issue Jun 26, 2024 · 4 comments
Open

Comments

@danielnaber
Copy link
Contributor

Adding a Slack connector asks for a "Workspace" without a description what that looks like. I added xyz.enterprise.slack.com - indexing works, but the links in the result contain a duplicated "slack.com", like https://xyz.enterprise.slack.com.slack.com/archives/ABCDEF/p12345?thread_ts=12345.12345. The URL is built by get_message_link() in slack/utils.py I think.

I haven't tested leaving out the .slack.com but if that's the correct way to specify a workspace, there should be a hint in the connector UI in that direction, or the code should remove .slack.com automatically.

@danielnaber
Copy link
Contributor Author

I haven't tested leaving out the .slack.com but if that's the correct way to specify a workspace

I can confirm now that the "workspace" setting mustn't contain .slack.com for the search result links to work.

@ATSiem
Copy link

ATSiem commented Sep 30, 2024

I am running Danswer on a local IP address, and all the links from my Zulip connector are broken (prepended actual Zulip realm_url with the local IP address).

@ATSiem
Copy link

ATSiem commented Sep 30, 2024

I haven't tested leaving out the .slack.com but if that's the correct way to specify a workspace

I can confirm now that the "workspace" setting mustn't contain .slack.com for the search result links to work.

@danielnaber What process did you use to change this?

@danielnaber
Copy link
Contributor Author

What process did you use to change this?

@ATSiem As far as I remember, I created a new connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants