-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Fatal error: getRemainingStreams() must be of the type int #103
Comments
But otherwise can you provide the full stack trace? We could be more defensive. Also, not sure if it can be related, but the prior URL looks very odd |
How do I provide a full stack trace? The httpx was me substituting in place of https to prevent it from being crawled here or becoming an actual URL, sorry. |
I'd assumed there was more of the stack trace in the original trace you provided? Maybe indicating at which point Fink called the Amp HTTP client? But no worries, there should be only one place that does that :D |
Maybe you could try changing: Line 86 in cc30101
to |
I don't understand "\Throwable" - replace the whole line with just that? |
No so that it becomes:
|
Okay, running. I also notice the above link that caused the error isn't actually a 404, so not sure why it thinks that it is. Perhaps it just took too long to respond? Here's the real link. |
hmm, it says 200 though? That link is also fine if I run it through fink directly -- but if it were caused by a link it would be the next one which isn't shown. |
Ah yes, apologies. It seems virtually every link that's somehow associated with social media or a "sharer.php" redirect fails. Here are two that were marked red that I managed to capture. Screenshot attached. Thanks for the great support. |
It failed again, perhaps due to the changes I made.
|
84 try { |
@dwreski Are you on a 32 bit platform? |
No. uname -a |
@dwreski Could you check whether amphp/http-client@d272ceb changes anything? |
I do not have the test directory on my installation, so I could not install that file. I did download and put in place the ./amphp/http-client/src/Connection/Internal/Http2ConnectionProcessor.php file, however. I ran it once and lost the connection to the server after what appeared to be about 7 minutes of run time. The second time it died with what appears to be a different error after just a minute or so.
|
Perhaps you'd like to run it on the site from where you are? It's a very large site with tens of thousands of articles, which is why I was running it locally, but given it typically dies pretty quickly, maybe it would be helpful. |
@dwreski btw that's the error due to the change I suggested, just switch it back to |
Okay, got it to run for almost an hour before choking again.
`[---] https://www.linkedin.com/shareArticle?mini=true&url=https://linuxsecurity.com/advisories/deblts/debian-lts-dla-1860-1-libxslt-security-update-12-16-47Concurrency: 10, Queue size: 12138, Failures: 2236/47627 (4.69%) |
Please try again with amphp/http-client@4cc8b27. I could reproduce it and it's running fine now for 20 minutes, after which I aborted. Previously it always failed at about 10 minutes. |
It appears to be running more reliably now, but it's finding a lot of links it considers to be 404s which are not. Not all of the "share" links are 404s, but a great majority of the "share" links are. Also, it would be good to be able to select a number of URLs to check at runtime, so I can get an idea of what the output looks like before having to wait for the whole site to complete. Perhaps it can start to write the 404 errors to a file so we can view them? Or extend the display beyond just five or six lines so we can view them on the screen as it's running? |
It would also be good to be able to resume a session. My connection to the server dropped after having run fink for more than three hours. It's too bad that all has to be done over. |
It managed to make its way through a complete run without failing. Do you have any recommendations on procedures to convert the JSON output into something more usable? Of course I could convert it into a CSV, but thought there might be something already set up to graph the data or display it in a more usable way? |
@dwreski You can use Please open a new issue for feature requests such as resumption. The 404s might also be some crawler prevention kicking in. |
I've tagged https://github.com/amphp/http-client/releases/tag/v4.4.1, which fixes this issue. |
This is after running successfully for more than an hour on our site (replaced with "example" here; link disabled). This is using the version available today. What more can I do to troubleshoot this?
The text was updated successfully, but these errors were encountered: