Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing implementation of intended functionality #17

Open
adamkolar opened this issue Nov 19, 2017 · 2 comments
Open

Possibly missing implementation of intended functionality #17

adamkolar opened this issue Nov 19, 2017 · 2 comments

Comments

@adamkolar
Copy link

adamkolar commented Nov 19, 2017

This comment:

        // Set to the index in the cooldown array (see below) that represents
        // the current cooldown duration for this Kitty. This starts at zero
        // for gen0 cats, and is initialized to floor(generation/2) for others.
        // Incremented by one for each successful breeding action, regardless
        // of whether this cat is acting as matron or sire.
        uint16 cooldownIndex;

says that cooldownIndex should be initialized to floor(generation/2) for all kitties with generation > 0. However I haven't found any code that implements this functionality, all kitties regardless of generation seem to start at 0.

@dete
Copy link

dete commented Nov 19, 2017

Nice catch, @adamkolar! We noticed this internally yesterday, but it's a fairly important miss so I'm going to leave this issue open for a bounty.

@kimcope
Copy link
Contributor

kimcope commented Nov 21, 2017

Thanks for your participation, @adamkolar! Our team has reviewed your submission, and we are pleased to reward you for your report.

Impact: Low
Likelihood: High
Points: 100

We are discounting the point number because this issue was already found and fixed internally.

Please see the final leaderboard here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants