Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that page-feedback events are usable with Google Analytics 4 #2943

Closed
chalin opened this issue Nov 8, 2022 · 3 comments
Closed

Ensure that page-feedback events are usable with Google Analytics 4 #2943

chalin opened this issue Nov 8, 2022 · 3 comments

Comments

@chalin
Copy link
Contributor

chalin commented Nov 8, 2022

If there's a feeling of urgency to collected page-feedback events in GA4, then the local partial layouts/partials/feedback.html will at least need to be updated to use the gtag.js library, and an event-modification rule implemented. For an example of how this has been implemented, see:

Specifically, kubernetes/website#37657 (comment).

If there is no feeling of urgency in gathering this data under GA4, then I'd suggesting waiting for the upstream fix and then updating Hugo.

@chalin
Copy link
Contributor Author

chalin commented Nov 8, 2022

I went ahead and created an event-modification rule, in case we get local changes into the project-local feedback-partial override before the Docsy fix lands:

image

@hhunter-ms
Copy link
Collaborator

@chalin would you say this issue is resolved?

@chalin
Copy link
Contributor Author

chalin commented Feb 23, 2023

Hi @hhunter-ms - yes in that I created the necessary event-modification rule, but it will only work for v1.7+ of the docs. I didn't close this issue at the time because I wasn't sure how far back in the doc versions you wanted analytics support for.

According to #2861 (comment), v1.7+ is good enough. Closing!

@chalin chalin closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants