Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actor reminder and timer period parameter #536

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

heunghingwan
Copy link
Contributor

Description

Allow undefined reminder and timer periods

Issue reference

issue this PR will close: #535

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: heunghingwan <heunghingwan@users.noreply.github.com>
@heunghingwan heunghingwan requested review from a team as code owners October 15, 2023 12:06
@shubham1172
Copy link
Member

Hi @heunghingwan, could you please add a test for this too? You could update the implementation here https://github.com/dapr/js-sdk/blob/main/test/actor/DemoActorReminderImpl.ts to take in a parameterized period, and use it in an e2e test.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b063e10) 100.00% compared to head (21aaa6f) 35.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #536       +/-   ##
============================================
- Coverage   100.00%   35.28%   -64.72%     
============================================
  Files            1       91       +90     
  Lines            6    10445    +10439     
  Branches         1      410      +409     
============================================
+ Hits             6     3686     +3680     
- Misses           0     6700     +6700     
- Partials         0       59       +59     
Files Coverage Δ
src/actors/client/ActorClient/ActorClientHTTP.ts 4.54% <0.00%> (ø)

... and 89 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: heunghingwan <heunghingwan@users.noreply.github.com>
Signed-off-by: heunghingwan <heunghingwan@users.noreply.github.com>
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR and adding tests @heunghingwan!

@shubham1172 shubham1172 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into dapr:main with commit 0fb83c1 Oct 26, 2023
6 of 8 checks passed
@heunghingwan heunghingwan deleted the patch-1 branch October 26, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actor timers and reminders should accept empty period parameter
2 participants