-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: pools silently fail to populate #79
Comments
Thanks for opening up this issue, I'll take a look at this later today. |
Checkout the Feel free to change it if you would like to keep these pools. |
cool, thanks for the quick response. i don't care about these pools but i don't want these empty/failed pools in the output. maybe we can add a check in |
We have a function pub fn remove_empty_amms(amms: Vec<AMM>) -> Vec<AMM> {} in the @0xKitsune What do you think |
hi, thanks for the lib, looks great 👍
i found several pools that don't populate properly and remain with all values initialized to zero. can verify with the following test:
the pools i found are
i don't see anything wrong with them on etherscan. it would be great if the
populate_data
method returned an error in this case rather than silently failingThe text was updated successfully, but these errors were encountered: