-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discover factories fails #87
Comments
same thing happens with BASE, using their RPC |
You can decrease the step when discovering factories as well as syncing. As a side note, we need to update our docs across the codebase so that things like this are clear. |
For Alchemy step = 50000 should work |
I tried on BASE, rpc_endpoint = "https://mainnet.base.org", step =2000 is the max, and it discovers only 1 factory, which is not correct : All factories discovered Also the data for this factory is not correct - creation block is wrong. However, I was doing some debugging and it seems meanwhile in identified_factories.insert(log.address, (factory, 0)); identified_factories grows to some reasonable size, like 100+ which is probably correct for BASE. further I noticed that : for (_, (factory, amms_length)) in identified_factories { why >= ? (amms_length >= number_of_amms_threshold { shouldn't it be <= ? |
As I understand this parameter exists to filter out AMMs/DEXes that are not "popular"/"active"/etc. You can set the threshold to More thoughts on this... |
Ah, just noticed that |
Yeah exactly, The |
The creation block number is actually a bug I think, thanks for bringing this up. We are setting the |
I am trying discover factories and it fails after a while with Discovering new factories...Error: Middleware error
this is using alchemy :
{
jsonrpc:"2.0",
id:174,
error:{
code:-32602,
message:"Log response size exceeded. You can make eth_getLogs requests with up to a 2K block range and no limit on the response size, or you can request any block range with a cap of 10K logs in the response. Based on your parameters and the response size limit, this block range should work: [0x1067380, 0x1072ee6]"
}
}
the request from our side :
{
id:174,
jsonrpc:"2.0",
method:"eth_getLogs",
params:[
{
fromBlock:"0x1067380",
toBlock:"0x107fa1f",
topics:[
[
"0x0d3648bd0f6ba80134a33ba9275ac585d9d315f0ad8355cddefde31afa28d0e9",
"0x783cca1c0412dd0d695e784568c96da2e9c22ff989357a2e8b1d9b2b4e6b7118"
]
]
}
]
}
The text was updated successfully, but these errors were encountered: