-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Factory discoveries within a range of blocks #99
Comments
Yeahh it's possible, but in the current architecture you'd have to change the code. Right now its defaulting with the let mut from_block = 0;
let current_block = middleware
.get_block_number()
.await
.map_err(AMMError::MiddlewareError)?
.as_u64(); amms-rs/src/discovery/factory.rs Line 50 in 00b2672
|
Yeah i've updated this feature in my branch. Should i create a PR? |
Yes, thanks for opening an issue, this would be a good feature to add since there aren't any factories to discover for ~6 mm blocks. In your PR can you also update the default |
I've created a PR #102. I choose the |
Is it possible that we can call
discover_factories
with block params so i could run the discoveries within a range of blocks? Fetching from block 0 could be time consuming and inefficient.The text was updated successfully, but these errors were encountered: