Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault in lighttable view #17382

Open
ilveroluca opened this issue Aug 27, 2024 · 5 comments
Open

Segmentation fault in lighttable view #17382

ilveroluca opened this issue Aug 27, 2024 · 5 comments

Comments

@ilveroluca
Copy link

Describe the bug

In lighttable view, darktable loads the last collection the last correction I successfully worked on. I then choose a different, old collection (2013) and darktable segfaults as it loads the image previews.

Steps to reproduce

  1. Open darktable
  2. Change film roll
  3. Wait while thumbnails load

Expected behavior

darktable should load previews without segfaulting

Logfile | Screenshot | Screencast

darktable-no-opencl.stdout.log
darktable-no-opencl.stderr.log

Commit

No response

Where did you obtain darktable from?

OBS

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

Ubuntu 24.04 LTS

Describe your system?

Kubuntu 24.04 desktop, 16 GB RAM.

17:54 [luca@box ~] inxi -G
Graphics:
  Device-1: NVIDIA TU116 [GeForce GTX 1660 SUPER] driver: nvidia v: 550.90.07
  Display: x11 server: X.Org v: 21.1.11 with: Xwayland v: 23.2.6 driver: X:
    loaded: modesetting,nouveau,nvidia unloaded: fbdev,vesa
    gpu: nvidia,nvidia-nvswitch resolution: 1: 2560x1440~60Hz 2: N/A

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA GeForce GTX 1660 SUPER, 6 GB, Nvidia Driver Version: 550.90.07

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

Tested with --disable-opencl: did not affect result.

I have found a specific image that triggers the issue. I can share the XMP and ORF (privately) if that can help debug the issue.

I have previously experienced a similar problem, which I reported in #17139; the fix to that problem should be in the version of darktable I'm using though.

@jenshannoschwalm
Copy link
Collaborator

Please mail me for investigation

hanno@schwalm-bremen.de

@ilveroluca
Copy link
Author

@jenshannoschwalm was unable to reproduce the problem on the current master. Maybe the problem has already been solved post 4.8.1.

I'm sharing the sidecar file here in case someone wants to take a look.

PC243238.ORF.xmp.txt

@ilveroluca
Copy link
Author

I have dug a little deeper. I'm finding that many of my images from that period are causing a crash.

Here's another example (raw + sidecar).

@ilveroluca
Copy link
Author

Digging some more...

I found a third picture that doesn't create any problems. I found the only operation that appears in the history of the two pictures causing the crash, but does not appear in the other one is clipping.

These are the 3 sidecar files -- two causing a crash and one not causing a crash:

  1. crash-one.xmp.txt
  2. crash-two.xmp.txt
  3. no-crash.xmp.txt

I scanned through the XML with basic text processing tools. These are the operations only appearing in the crashing histories:

$ comm -2 -3 <(grep operation crash-one.xmp.txt | sort)  <(grep operation no-crash.xmp.txt | sort)
      darktable:operation="clipping"
$ comm -2 -3 <(grep operation crash-two.xmp.txt | sort)  <(grep operation no-crash.xmp.txt | sort)
      darktable:operation="bilateral"
      darktable:operation="clipping"

@jenshannoschwalm
Copy link
Collaborator

Thanks for this hint! Clip module is deprecated and we probably missed to make sure the new stuff fits for that module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ilveroluca @jenshannoschwalm and others