-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic in Caddy plugin #433
Comments
Hi @knadh thank you for your issue. The panic comes from the singleflight package, I have to check why that happens, which "map" is concurrently accessed/written. That's a high priority bugfix. It would be great to have a reproducible test case 🙂 |
This is from a site that receives few a thousand requests per minute. Have been unable to pinpoint what triggers this, unfortunately. Sometimes it's a few seconds between crashes, sometimes it's half an hour. I've disabled caching altogether. |
I will use the stress tests to debug that then. |
@knadh With this config
|
I saw similar errors relating to souin and singleflight just now, and this crashed my Caddy. Small site, literally mostly just me browsing it while developing and writing. I'll keep monitoring in case this crash pops up again. |
@rask can you open a new issue with the logs you got and some context please? 🙏 |
Hi @darkweak. The following configuration runs fine and after an arbitrary time handling traffic, panics and crashes Caddy. I'm using the latest build created with
xcaddy build --with github.com/darkweak/souin/plugins/caddy --with github.com/darkweak/souin
The text was updated successfully, but these errors were encountered: