Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a switch on GUI interface in order to control cropping options #18

Closed
lepoulet44 opened this issue Dec 5, 2022 · 4 comments · Fixed by #19
Closed

Adding a switch on GUI interface in order to control cropping options #18

lepoulet44 opened this issue Dec 5, 2022 · 4 comments · Fixed by #19
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lepoulet44
Copy link

Hi.
Thanks for adding scribe profile to kcc. And many thanks for keeping this nice tool up to date.

Would it be possible to add a switch on gui interface in order to control the cropping options? (disable, margin, margin+page numbers)

(Understood that it is availabe on CLI version but my super noob skillls didn't allow me to make it work)

@darodi darodi self-assigned this Dec 9, 2022
@darodi darodi added enhancement New feature or request good first issue Good for newcomers question Further information is requested and removed good first issue Good for newcomers labels Dec 9, 2022
@darodi
Copy link
Owner

darodi commented Dec 9, 2022

Hello @lepoulet44

By default, the GUI is using those options:

  • cropping: Margins + page numbers
  • cropping power 1.0

Is this not good enough for you?

    -c CROPPING, --cropping=CROPPING
                        Set cropping mode. 0: Disabled 1: Margins 2: Margins +
                        page numbers [Default=2]
    --cp=CROPPINGP, --croppingpower=CROPPINGP
                        Set cropping power [Default=1.0]

@darodi darodi added the good first issue Good for newcomers label Dec 9, 2022
@lepoulet44
Copy link
Author

Thanks a lot for your time and your hard work.

Most of the time, converting mangas or comics, the default cropping options are perfect and i wouldn't change them. Especially on a small device.

But for some graphic novels, in rare occasions, it can ruin the intention of the artists, zooming and centering small details on a blank page.

Some larger devices, like the kindle Scribe or the kobo Elipsa are now available, and perhaps the possibility to keep the exact aspect of the pages could make sense on big screens?

@darodi
Copy link
Owner

darodi commented Dec 9, 2022

I'll have a look to add that option in the GUI

@darodi darodi removed the question Further information is requested label Dec 9, 2022
@4AM-Campfire
Copy link

An option to completely disable cropping would be welcome.

Removing the intentional white space from pages makes for a very jarring reading experience with layouts that make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants