Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread splitter not keeping aspect ratio #27

Closed
Zaphain opened this issue Dec 29, 2022 · 8 comments · Fixed by #28
Closed

Spread splitter not keeping aspect ratio #27

Zaphain opened this issue Dec 29, 2022 · 8 comments · Fixed by #28
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested

Comments

@Zaphain
Copy link

Zaphain commented Dec 29, 2022

When using split and rotate, regardless whether upscaling is set to keep the aspect ratio, the resulting three images will all be stretched to the full resolution. I'm unsure if this is a bug in behavior or whether I should be asking for an added option to have the aspect ratio preserved here and the images instead be centered.

@darodi
Copy link
Owner

darodi commented Dec 29, 2022

@Zaphain

Do you have an input example ?

@darodi darodi assigned darodi and unassigned darodi Dec 29, 2022
@darodi darodi added the question Further information is requested label Dec 29, 2022
@Zaphain
Copy link
Author

Zaphain commented Dec 29, 2022

https://imgur.com/a/XQ0QNIR
On closer look, it seems the rotated image is fine, it's just the split ones. Those are definitely stretched. The correct aspect ones were just done in imagemagick to show what I think it should be. (There's a typo in one of the image descriptions, but nevermind that, you can tell what I mean)

Also, I think if you wanted to keep more of the feeling of the pages being connected, you could left align image b, and right align image c. That might be best instead of centered.

@xMonTersx
Copy link

I could confirm that issue happen to me too.
I run KCC in webtoon mode, option Strech/upscale had been auto-checked, but the ratio of the result are not keep

@darodi
Copy link
Owner

darodi commented Dec 30, 2022

@Zaphain

I'm unable to reproduce your problem.
With those settings:
image

I get the following, where orig.jpg is the original image
result.zip

@darodi darodi added the bug Something isn't working label Dec 30, 2022
@Zaphain
Copy link
Author

Zaphain commented Dec 30, 2022

...With those settings: image

Okay, I see where the issue is, this doesn't happen when epub is chosen as the output, it's only affecting the KFX output. https://imgur.com/a/uqDTyo7

@darodi
Copy link
Owner

darodi commented Dec 30, 2022

OK, it must be here in the code.
KFX mode is stretching for split images

if self.opt.stretch or (self.opt.kfx and ('-KCC-B' in self.targetPath or '-KCC-C' in self.targetPath)):
self.image = self.image.resize(self.size, method)

@darodi
Copy link
Owner

darodi commented Dec 30, 2022

I've tested with Calibre and KFX Conversion Output Plugin without the stretch.
It works. I'll commit this and make a new release.
I must admit I've never used the KFX output before, only MOBI files.

@xMonTersx
Copy link

@darodi
Could you please check this issues with these setting. The ratio is not keep
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants