Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Unify DDC SDK with Dart repo's SDK #257

Closed
6 tasks
jmesserly opened this issue Jul 15, 2015 · 9 comments
Closed
6 tasks

Unify DDC SDK with Dart repo's SDK #257

jmesserly opened this issue Jul 15, 2015 · 9 comments

Comments

@jmesserly
Copy link
Contributor

jmesserly commented Jul 15, 2015

DDC compiles against the Dart SDK that is installed, but runs against an older built snapshot from our implementation. Here's the plan to fix that:

  • delete our 1.9 copy. Replace with latest.
  • figure out how we store latest SDK. Ideally we don't check it in. Maybe DEPS or git submodules to point at a hash file?
  • try to patch against our impls. It's an error if the patch files don't line up.
  • fix the impls if needed (i.e. implement new APIs that are lacking DDC impl)
  • save the JS file as well as DDC summary
  • DDC must compile against its own SDK summary (otherwise there's no guarantee the impls will work)

thanks to @vsmenon for helping me brainstorm this :)

@munificent
Copy link
Contributor

I'll take dart:async.

@vsmenon
Copy link
Contributor

vsmenon commented May 5, 2016

@jacob314 will look at dart:html once dart:async is landed

@munificent
Copy link
Contributor

dart:async is done as of 8154650

@munificent
Copy link
Contributor

Working on Uri and probably dart:convert (since Uri uses it) now.

@rakudrama
Copy link
Contributor

Blocked by #253:
lib/collection/linked_list.dart
lib/collection/queue.dart
lib/collection/splay_map.dart

@munificent
Copy link
Contributor

OK, Uri and dart:convert are landed, though @floitschG says there may be some more dart:convert changes coming soon after. What's left to do?

@munificent munificent changed the title upgrade DDC sdk Unify DDC SDK with Dart repo's SDK May 11, 2016
@munificent
Copy link
Contributor

This issue was originally about unforking DDC's SDK but we've been using it to refer to rolling it. To disambiguate, I'm forking the bug. This one is now about unforking. The bug for just rolling the latest SDK is #565.

@jmesserly
Copy link
Contributor Author

I investigated DDC summary. We can produce it with new Analyzers, but we can't build tests against it because some packages and a few tests seem to depend on dart:io (not sure if they use much of it or what's up there).

@jmesserly
Copy link
Contributor Author

This issue was moved to dart-lang/sdk#27314

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants