Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build all source files – even if just targeting web, test, etc #1454

Closed
kevmoo opened this issue May 16, 2018 · 2 comments
Closed
Assignees

Comments

@kevmoo
Copy link
Member

kevmoo commented May 16, 2018

I have a generated file in example.

Right now, it's deleted when running pbr test. I'd expect it to always be generated.

@jakemac53
Copy link
Contributor

jakemac53 commented May 16, 2018

To be clear - it only gets deleted if the build was invalidated since the last run, but that is still a weird edge case.

In general, its seems safest to always rebuild any build to source files though since they are shipped with the package. It is a common workflow to run your tests before publishing, and if doing so in any way can delete files you actually need in your published package, then that seems broken.

@jakemac53 jakemac53 self-assigned this May 16, 2018
@natebosch
Copy link
Member

In general, its seems safest to always rebuild any build to source files though since are shipped with the package.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants