Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Builder.build to FutureOr<void> #535

Closed
matanlurey opened this issue Oct 20, 2017 · 5 comments
Closed

Change Builder.build to FutureOr<void> #535

matanlurey opened this issue Oct 20, 2017 · 5 comments
Assignees
@jakemac53
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump P3 A lower priority bug or feature request package:build type-enhancement A request for a change that isn't a bug type-question A question about expected behavior or functionality
Milestone
v1.0.0

Comments

@matanlurey
Copy link
Contributor

Prepares for FutureOr<void>, and doesn't require adding async to your method body.

... though maybe all of this is not too important if post-Barback we can make methods sync?
@matanlurey matanlurey added package:build type-question A question about expected behavior or functionality labels Oct 20, 2017
@jakemac53
Copy link
Contributor

jakemac53 commented Oct 20, 2017 •
edited
Loading

Not sure what you meant re: post-barback, but in general this SGTM.

We already made a similar change in source_gen because somebody requested it dart-lang/source_gen#250.

@matanlurey
Copy link
Contributor Author

matanlurey commented Nov 3, 2017 •
edited
Loading

Seems like this isn't really worth it since Future<void> is rolling out.

We can wait until then.

Related issue:
dart-lang/sdk#31278

@matanlurey matanlurey added the type-enhancement A request for a change that isn't a bug label Nov 3, 2017
@jakemac53 jakemac53 added the P3 A lower priority bug or feature request label Jan 8, 2018
@natebosch natebosch mentioned this issue Jan 18, 2018
Closed
@jakemac53
Copy link
Contributor

Ping on this, @natebosch @matanlurey @grouma should we implement this for 1.0.0 or should we close the issue?

@natebosch
Copy link
Member

Yes, I'd like to get this in for 1.0.0

@natebosch natebosch changed the title Change Builder.build to FutureOr<Null>? Change Builder.build to FutureOr<void> Sep 11, 2018
@matanlurey
Copy link
Contributor Author

matanlurey commented Sep 11, 2018 •
edited
Loading

Nit: should be void now not Null :)

@jakemac53 jakemac53 added this to the v1.0.0 milestone Sep 11, 2018
@natebosch natebosch added the next-breaking-release Issues that are worth doing but need to wait for a breaking version bump label Sep 19, 2018
@jakemac53 jakemac53 mentioned this issue Sep 24, 2018
Merged
@jakemac53 jakemac53 self-assigned this Sep 24, 2018
@eernstg eernstg mentioned this issue Jul 27, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump P3 A lower priority bug or feature request package:build type-enhancement A request for a change that isn't a bug type-question A question about expected behavior or functionality
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@matanlurey @jakemac53 @natebosch