Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update factory constructors tests according to the changed specification #2351

Closed
sgrekhov opened this issue Nov 3, 2023 · 1 comment
Closed

Update factory constructors tests according to the changed specification #2351

sgrekhov opened this issue Nov 3, 2023 · 1 comment
Assignees
@sgrekhov
Labels
closed-duplicate Closed in favor of an existing report

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 3, 2023

The current factory constructors tests are mainly written in 2011 and don't check a lot of the statements in the current spec. In particular there are no tests for enums. Need to update them and add missed tests
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 3, 2023
@sgrekhov sgrekhov self-assigned this Nov 3, 2023
@sgrekhov sgrekhov added closed-duplicate Closed in favor of an existing report and removed type-enhancement A request for a change that isn't a bug labels Nov 3, 2023
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Nov 3, 2023

Duplicate of #2350

@sgrekhov sgrekhov marked this as a duplicate of #2350 Nov 3, 2023
@sgrekhov sgrekhov closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov