Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow host pages to call DartPad inject feature, rather than autorun #1390

Closed
chalin opened this issue Nov 22, 2019 · 1 comment
Closed

Allow host pages to call DartPad inject feature, rather than autorun #1390

chalin opened this issue Nov 22, 2019 · 1 comment
Labels
inject-script P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone

Comments

@chalin
Copy link

chalin commented Nov 22, 2019

AFAIK, the DartPad inject feature upon loading, queries a host page looking for code blocks with a run-dartpad class and replaces these blocks by DartPad iframes.

The following might be possible already, but it would be nice if the user could invoke the DartPad inject functionality by, say, clicking on a "Open in DartPad" button that would be shown over a code block or tabbed code block as is shown below. This could help reduce the time to load pages with embedded DartPads.

image

image

Of course the button would be an element in the host page. What we need is a point of call for the inject function.

cc @kwalrath @legalcodes

@RedBrogdon RedBrogdon added type-enhancement A request for a change that isn't a bug inject-script P2 A bug or feature request we're likely to work on labels Nov 26, 2019
@RedBrogdon RedBrogdon added this to the Backlog milestone Nov 26, 2019
@parlough
Copy link
Member

Thanks for tracking this. Definitely would be nice to have!

Superseded by #2702 (comment)

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inject-script P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants