Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't launch dart.dev #2038

Closed
johnpryan opened this issue Oct 12, 2021 · 8 comments
Closed

Can't launch dart.dev #2038

johnpryan opened this issue Oct 12, 2021 · 8 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone

Comments

@johnpryan
Copy link
Contributor

johnpryan commented Oct 12, 2021

See this gist

Screenshot Screen Shot 2021-10-12 at 11 36 22 AM
@johnpryan
Copy link
Contributor Author

@mdebbar this only happens in DartPad, so I'm wondering if there's some additional configuration needed on the iframe that hosts the Flutter app?

@parlough
Copy link
Member

parlough commented Oct 12, 2021

I don't have a chance to take a look at this for a little while, but I'm assuming this would be due to my changes to dart.dev's security policies in dart-lang/site-www#3540

Before then, if we need to make modifications or revert those changes let me know.

@johnpryan
Copy link
Contributor Author

I created flutter/website#6381 to track this for the Flutter website too. We might consider making an exception for DartPad. Thanks for the context!

@RedBrogdon RedBrogdon added the P2 A bug or feature request we're likely to work on label Oct 14, 2021
@RedBrogdon
Copy link
Contributor

@johnpryan Should this be closed here? It's not actually a DartPad issue, right?

@RedBrogdon RedBrogdon added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Oct 14, 2021
@RedBrogdon RedBrogdon added this to the Backlog milestone Oct 14, 2021
@kwalrath
Copy link

Should we file this as a dart-lang/site-www issue?

@srawlins
Copy link
Member

I'm seeing this in one of our key Firebase apps (#1946), can we bump the priority?

@johnpryan
Copy link
Contributor Author

The dart.dev issue is fairly minor: dart-lang/site-www#3629.

#1946 looks like higher priority, but separate issue, so I'll close this.

@parlough
Copy link
Member

parlough commented Oct 16, 2021

@johnpryan Taking a look, some of this appears to be due to the security policy on the dart.dev end, but part of it appears to perhaps be the iframe like you mentioned (or url_launcher, I'm not sure?). For example, when you launch https://pub.dev with the script you mentioned, you also will get various errors due to the lack of frame permissions when searching.

Screenshot of pub.dev errors:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants