-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for the new super mixins #850
Comments
Overall feature tracking issue here: dart-lang/language#12 |
mixin keyword will not be highlighted until this gets done. |
Backend is working, and even without this the supermixin support is probably enough for day one, so not a blocking bug. |
done? |
@devoncarew I thought there was some syntax highlighting that we wanted, even if it wasn't completely blocking |
if the syntax highlighting is a blocker let me know and I can try and chase it down. |
Hmm, yes, I forgot. We need to update (https://github.com/google/codemirror.dart/blob/master/updating_codemirror.md) codemirror.dart to the latest, and then publish that package.
If you'd like to do it, sounds great; I'm having some issues running (and updating) bower on my machine |
CodeMirror was updated as a side effect of our work on the new embed UI. It looks like this is working to me. Just tested with:
I'm seeing correct highlighting for the mixin keyword, and no weird warnings/errors. |
Bumps [build_runner](https://github.com/dart-lang/build) from 2.1.8 to 2.1.10. - [Release notes](https://github.com/dart-lang/build/releases) - [Commits](dart-lang/build@build_daemon-v2.1.8...build_runner-v2.1.10) --- updated-dependencies: - dependency-name: build_runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brett Morgan <brettmorgan@google.com>
This has two parts:
The text was updated successfully, but these errors were encountered: