Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the new super mixins #850

Closed
1 of 2 tasks
Tracked by #12
devoncarew opened this issue Sep 5, 2018 · 8 comments
Closed
1 of 2 tasks
Tracked by #12

add support for the new super mixins #850

devoncarew opened this issue Sep 5, 2018 · 8 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

devoncarew commented Sep 5, 2018

This has two parts:

  • updating the backend with analysis and compile support, when the implementations are ready
  • updating the front-end with the new syntax highlighting; this depends on a new publish of codemirror.dart, which itself needs a new release of the codemirror library (the change to codemirror JS is already in, and releases can be tracked here: https://github.com/codemirror/CodeMirror/releases)
@devoncarew
Copy link
Member Author

Overall feature tracking issue here: dart-lang/language#12

@jcollins-g
Copy link
Contributor

mixin keyword will not be highlighted until this gets done.

@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label Oct 19, 2018
@jcollins-g
Copy link
Contributor

Backend is working, and even without this the supermixin support is probably enough for day one, so not a blocking bug.

@jcollins-g jcollins-g added the type-enhancement A request for a change that isn't a bug label Oct 19, 2018
@devoncarew
Copy link
Member Author

done?

@jcollins-g
Copy link
Contributor

@devoncarew I thought there was some syntax highlighting that we wanted, even if it wasn't completely blocking

@jcollins-g
Copy link
Contributor

if the syntax highlighting is a blocker let me know and I can try and chase it down.

@devoncarew
Copy link
Member Author

Hmm, yes, I forgot. We need to update (https://github.com/google/codemirror.dart/blob/master/updating_codemirror.md) codemirror.dart to the latest, and then publish that package.

let me know and I can try and chase it down

If you'd like to do it, sounds great; I'm having some issues running (and updating) bower on my machine

@RedBrogdon
Copy link
Contributor

RedBrogdon commented Apr 22, 2019

CodeMirror was updated as a side effect of our work on the new embed UI. It looks like this is working to me.

Just tested with:

class blah with Musical {}

mixin Musical {
  bool canPlayPiano = false;
  bool canCompose = false;
  bool canConduct = false;

  void entertainMe() {
    if (canPlayPiano) {
      print('Playing piano');
    } else if (canConduct) {
      print('Waving hands');
    } else {
      print('Humming to self');
    }
  }
}

void main() {
  final b = blah();
  b.entertainMe();
}

I'm seeing correct highlighting for the mixin keyword, and no weird warnings/errors.

johnpryan pushed a commit to johnpryan/dart-pad that referenced this issue Jun 27, 2023
Bumps [build_runner](https://github.com/dart-lang/build) from 2.1.8 to 2.1.10.
- [Release notes](https://github.com/dart-lang/build/releases)
- [Commits](dart-lang/build@build_daemon-v2.1.8...build_runner-v2.1.10)

---
updated-dependencies:
- dependency-name: build_runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants