Update specification for generative constructors #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Dec 6, 2024
| @@ -932,8 +907,12 @@ potentially non-redirecting property of the constructor. | |||
|
|
|||
| It is a compile-time error if: | |||
|
|
|||
| * The augmented constructor has an initializer list or a body, or it has a | |||
| redirection. | |||
| * The augmented constructor has any initializers. | |||
There was a problem hiding this comment.
An initializer list can contain assertions, a superinitializer, and elements of the form n = e or this.n = e. If 'initializers' are only the third kind then we should consider adding the others explicitly.
There was a problem hiding this comment.
This is intended to cover all 3 forms (afaik a redirecting constructor cannot contain any of those?)
Co-authored-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a paired down version of #4164.
It contains only the changes to the proposal we had previously discussed, making
augmentedhave no special meaning in generative constructor bodies.It does not change rules around initializing formals or super parameters (these must be consistent across the introductory and any augmenting declarations still).
I wanted to separate out this change from the much more complicated explanation of how these constructors should be evaluated.