We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The prefer_final_parameters rule has tests indicating that it should report constructor parameters:
prefer_final_parameters
class C { C.badValue(String value): this.value = value; // LINT }
but not for field formal parameters:
class C { C.goodValue(this.value); // OK }
So, what about super-parameters? Whether it should or shouldn't, there should be a test.
The text was updated successfully, but these errors were encountered:
A super parameter is final even without the final modifier, just like an initializing formal, so it seems superfluous to ask for the modifier.
final
Sorry, something went wrong.
I'm happy to submit the test case.
Thanks @srawlins!
Successfully merging a pull request may close this issue.
The
prefer_final_parameters
rule has tests indicating that it should report constructor parameters:but not for field formal parameters:
So, what about super-parameters? Whether it should or shouldn't, there should be a test.
The text was updated successfully, but these errors were encountered: