From 92205756e723dda81a3530a2fcd15c4f215cb46d Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 1 Jul 2024 17:28:32 +0200 Subject: [PATCH] Move to separate method (and library) --- bin/pana.dart | 47 ++--------------------------------------- lib/src/logging.dart | 50 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 45 deletions(-) diff --git a/bin/pana.dart b/bin/pana.dart index 29d3cceef..fc7065915 100755 --- a/bin/pana.dart +++ b/bin/pana.dart @@ -13,6 +13,7 @@ import 'package:io/ansi.dart'; import 'package:io/io.dart'; import 'package:logging/logging.dart' as log; import 'package:pana/pana.dart'; +import 'package:pana/src/logging.dart'; import 'package:path/path.dart' as p; const defaultHostedUrl = 'https://pub.dev'; @@ -132,22 +133,7 @@ Future main(List args) async { } log.Logger.root.level = log.Level.ALL; - - if (isJson) { - log.Logger.root.onRecord.listen((log) { - final map = { - if (log.loggerName.isNotEmpty) 'logName': log.loggerName, - 'level': log.level.name, - 'message': log.message, - if (log.error != null) 'error': log.error.toString(), - if (log.stackTrace != null) 'stackTrace': log.stackTrace.toString(), - }; - - stderr.writeln(json.encode(map)); - }); - } else { - log.Logger.root.onRecord.listen(_logWriter); - } + initializePanaLogging(isJson: isJson); // Docker is WEIRD // The SIGTERM signal sent to `docker run...` DOES propagate a signal to the @@ -275,35 +261,6 @@ Future main(List args) async { await subscription.cancel(); } -void _logWriter(log.LogRecord record) { - var wroteHeader = false; - - final output = []; - final prefix = '${record.time} ${record.level.name}:'; - final emptyPrefix = ' ' * prefix.length; - void printLinesWithPrefix(String lines) { - for (final line in lines.split('\n')) { - final currentPrefix = wroteHeader ? emptyPrefix : prefix; - output.add('$currentPrefix $line'); - wroteHeader = true; - } - } - - printLinesWithPrefix(record.message); - final e = record.error; - if (e != null) { - printLinesWithPrefix(e.toString()); - final st = record.stackTrace; - if (st != null) { - printLinesWithPrefix(st.toString()); - } - } - - overrideAnsiOutput(stderr.supportsAnsiEscapes, () { - stderr.writeln(darkGray.wrap(output.join('\n'))); - }); -} - /// A merged stream of all signals that tell the test runner to shut down /// gracefully. /// diff --git a/lib/src/logging.dart b/lib/src/logging.dart index 3300ac830..f1f5344fa 100644 --- a/lib/src/logging.dart +++ b/lib/src/logging.dart @@ -3,7 +3,10 @@ // BSD-style license that can be found in the LICENSE file. import 'dart:async'; +import 'dart:convert'; +import 'dart:io'; +import 'package:io/ansi.dart'; import 'package:logging/logging.dart'; final Logger _log = Logger('pana'); @@ -16,3 +19,50 @@ Future withLogger(Future Function() fn, {Logger? logger}) => runZoned( ); Logger get log => (Zone.current[_key] as Logger?) ?? _log; + +void initializePanaLogging({bool isJson = false}) { + if (isJson) { + Logger.root.onRecord.listen((log) { + final map = { + if (log.loggerName.isNotEmpty) 'logName': log.loggerName, + 'level': log.level.name, + 'message': log.message, + if (log.error != null) 'error': log.error.toString(), + if (log.stackTrace != null) 'stackTrace': log.stackTrace.toString(), + }; + + stderr.writeln(json.encode(map)); + }); + } else { + Logger.root.onRecord.listen(_logWriter); + } +} + +void _logWriter(LogRecord record) { + var wroteHeader = false; + + final output = []; + final prefix = '${record.time} ${record.level.name}:'; + final emptyPrefix = ' ' * prefix.length; + void printLinesWithPrefix(String lines) { + for (final line in lines.split('\n')) { + final currentPrefix = wroteHeader ? emptyPrefix : prefix; + output.add('$currentPrefix $line'); + wroteHeader = true; + } + } + + printLinesWithPrefix(record.message); + final e = record.error; + if (e != null) { + printLinesWithPrefix(e.toString()); + final st = record.stackTrace; + if (st != null) { + printLinesWithPrefix(st.toString()); + } + } + + overrideAnsiOutput(stderr.supportsAnsiEscapes, () { + stderr.writeln(darkGray.wrap(output.join('\n'))); + }); +}