Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pub client: update solver to support language version 2.12 in Dart 3 #3554

Closed
jonasfj opened this issue Sep 6, 2022 · 1 comment · Fixed by #3572
Closed

pub client: update solver to support language version 2.12 in Dart 3 #3554

jonasfj opened this issue Sep 6, 2022 · 1 comment · Fixed by #3572
Assignees
@sigurdm
Labels
type-enhancement A request for a change that isn't a bug

Comments

@jonasfj
Copy link
Member

jonasfj commented Sep 6, 2022

Implement option C from go/dart-2 -in-dart-3.

Specially, intepret an SDK constraint where:

  • Lower-bound is >=2.12.0 or higher, and,
  • Upper-bound is <3.0.0.

Remark We may have to take extra care that error messages remain sane.
@mit-mit mit-mit changed the title Patch pub solver to support language version 2.12 in Dart 3 pub client: update solver to support language version 2.12 in Dart 3 Sep 7, 2022
@mit-mit mit-mit mentioned this issue Sep 7, 2022
Closed
9 tasks
@sigurdm sigurdm assigned sigurdm and unassigned jonasfj Sep 20, 2022
@sigurdm sigurdm mentioned this issue Sep 23, 2022
Merged
@mit-mit mit-mit mentioned this issue Sep 27, 2022
Closed
11 tasks
@mit-mit
Copy link
Member

mit-mit commented Oct 24, 2022

Confirmed working as intended in a locally patched 3.0 build after #3600 was fixed in #3612

@sigurdm sigurdm mentioned this issue Jan 19, 2023
Closed
@sigurdm sigurdm added type-enhancement A request for a change that isn't a bug and removed feature-request labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigurdm sigurdm

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make >=2.12 <3.0.0 compatible with dart 3 sigurdm/pub
3 participants
@jonasfj @sigurdm @mit-mit