-
Notifications
You must be signed in to change notification settings - Fork 1.6k
/
unintended_html_in_doc_comment.dart
238 lines (213 loc) · 5.53 KB
/
unintended_html_in_doc_comment.dart
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:collection/collection.dart';
import '../analyzer.dart';
const _desc = r'Use of angle brackets in a doc comment is treated as HTML by '
'Markdown.';
/// Valid HTML tags that should not be linted.
///
/// These tags are from
/// [CommonMark 0.30](https://spec.commonmark.org/0.30/#raw-html).
const _validHtmlTags = [
'a',
'abbr',
'address',
'area',
'article',
'aside',
'audio',
'b',
'bdi',
'bdo',
'blockquote',
'br',
'button',
'canvas',
'caption',
'cite',
'code',
'col',
'colgroup',
'data',
'datalist',
'dd',
'del',
'dfn',
'div',
'dl',
'dt',
'em',
'fieldset',
'figcaption',
'figure',
'footer',
'form',
'h1',
'h2',
'h3',
'h4',
'h5',
'h6',
'header',
'hr',
'i',
'iframe',
'img',
'input',
'ins',
'kbd',
'keygen',
'label',
'legend',
'li',
'link',
'main',
'map',
'mark',
'meta',
'meter',
'nav',
'noscript',
'object',
'ol',
'optgroup',
'option',
'output',
'p',
'param',
'pre',
'progress',
'q',
's',
'samp',
'script',
'section',
'select',
'small',
'source',
'span',
'strong',
'style',
'sub',
'sup',
'table',
'tbody',
'td',
'template',
'textarea',
'tfoot',
'th',
'thead',
'time',
'title',
'tr',
'track',
'u',
'ul',
'var',
'video',
'wbr',
];
class UnintendedHtmlInDocComment extends LintRule {
UnintendedHtmlInDocComment()
: super(
name: LintNames.unintended_html_in_doc_comment,
description: _desc,
);
@override
LintCode get lintCode => LinterLintCode.unintended_html_in_doc_comment;
@override
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
var visitor = _Visitor(this);
registry.addComment(this, visitor);
}
}
/// Represents the [offset] and [length] of an unintended HTML tag in a doc
/// comment.
class _UnintendedTag {
final int offset;
final int length;
_UnintendedTag(this.offset, this.length);
}
class _Visitor extends SimpleAstVisitor<void> {
/// Pattern for HTML-tags and non-HTML regions.
///
/// Pattern which matches sequences of characters with content that is known
/// to *not* be interpreted as Markdown or HTML tags, and anything else that
/// looks like an HTML tag.
/// Because [RegExp.allMatches] matches do not overlap, including the
/// non-HTML sections in the same RegExp ensures that the HTML tag match
/// will not be matched against the non-HTML content.
static final _markdownTokenPattern = RegExp(
// Escaped Markdown character, including `\<` and `\\`.
r'\\.'
// Or a Markdown code span, from "`"*N to "`"*N.
// Also matches an unterminated start tag to avoid "```a``"
// being matched as "``a``".
// The ```-sequence is atomic.
r'|(?<cq>`+)(?:[^]+?\k<cq>)?'
// Or autolink, starting with scheme + `:`, followed by non-whitespace/
// control characters until a closing `>`.
r'|<[a-z][a-z\d\-+.]+:[^\x00-\x20\x7f<>]*>'
// Or HTML comments.
r'|<!--(?:-?>|[^]*?-->)'
// Or HTML declarations, like `<!DOCTYPE ...>`.
r'|<![a-z][^]*?!>'
// Or HTML processing instructions.
r'|<\?[^]*?\?>'
// Or HTML CDATA sections sections.
r'|<\[CDATA[^]*\]>'
// Or plain `[...]` which DartDoc interprets as Dart source links,
// and which can contain type parameters like `... [List<int>] ...`.
// Here recognized as `[...]` with no `]` inside, not preceded by `]`
// or followed by `(` or `[`.
r'|(?<!\])\[[^\]]*\](?![(\[])'
// Or valid HTML tag.
// Matches `<validTag>`, `<validTag ...>`, `<validTag/>`, `</validTag>`
// and `</validTag ...>.
r'|<(?<et>/?)(?:'
'${_validHtmlTags.join('|')}'
r')'
r'(?:/(?=\k<et>)>|>|[\x20\r\n\t][^]*?>)'
// Or any of the following matches which are considered invalid tags.
// If the "nh" capture group is participating, one of these matched.
r'|(?<nh>)(?:'
// Any other `</?tag ...>` sequence.
r'</?[a-z][^]*?>'
r')', caseSensitive: false);
final LintRule rule;
_Visitor(this.rule);
@override
void visitComment(Comment node) {
var codeBlockLines =
node.codeBlocks.map((codeBlock) => codeBlock.lines).flattened;
for (var token in node.tokens) {
// Make sure that the current doc comment line isn't contained in a code
// block.
var offsetAfterSlash = token.offset + 3;
var inCodeBlock = codeBlockLines.any((codeBlockLine) =>
codeBlockLine.offset <= offsetAfterSlash &&
offsetAfterSlash <= codeBlockLine.offset + codeBlockLine.length);
if (inCodeBlock) continue;
var tags = _findUnintendedHtmlTags(token.lexeme);
for (var tag in tags) {
rule.reportLintForOffset(token.offset + tag.offset, tag.length);
}
}
}
/// Finds tags that are not valid HTML tags, not contained in a code span, and
/// are not autolinks.
List<_UnintendedTag> _findUnintendedHtmlTags(String text) {
var matches = <_UnintendedTag>[];
for (var match in _markdownTokenPattern.allMatches(text)) {
if (match.namedGroup('nh') != null) {
matches.add(_UnintendedTag(match.start, match.end - match.start));
}
}
return matches;
}
}