From d9aaa9b7922d4b3e5e540cf777d65f376a232d84 Mon Sep 17 00:00:00 2001 From: Alexander Thomas Date: Mon, 22 Mar 2021 18:39:20 +0000 Subject: [PATCH] Reland "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12" This reverts commit 88ee3334087b6a66d9f258c8fd9e014846266bc7. Reason for revert: Hook added by mistake removed. Original change's description: > Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12" > > This reverts commit 03e8ddd13c26eeb0c162c47ee76cfc239c43bdd6. > > Reason for revert: Change to hooks does not work with Windows. > > Original change's description: > > [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12 > > > > 2021-03-22 sgrekhov@unipro.ru Fixes #1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE > > 2021-03-22 sgrekhov@unipro.ru Fixes #1027. Typo fixed > > 2021-03-22 sgrekhov@unipro.ru Fixes #1026. Missed experimental flag added > > 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems > > 2021-03-19 sgrekhov@unipro.ru #1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS > > > > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try > > Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303 > > Reviewed-by: William Hesse > > Commit-Queue: Alexander Thomas > > TBR=whesse@google.com,athom@google.com > > Change-Id: I5f66db541034377f5d68424073282080d13fd34b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try > Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try > Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try > Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380 > Reviewed-by: William Hesse # Not skipping CQ checks because this is a reland. Change-Id: Ie54fde2d92d1b2cdb3b70835f1f8c17e3c5ac477 Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192384 Reviewed-by: Alexander Thomas Reviewed-by: William Hesse --- DEPS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/DEPS b/DEPS index 225447d18395..a2adf4554c5a 100644 --- a/DEPS +++ b/DEPS @@ -44,7 +44,7 @@ vars = { # co19 is a cipd package. Use update.sh in tests/co19[_2] to update these # hashes. It requires access to the dart-build-access group, which EngProd # has. - "co19_rev": "1abf208ef6428aac8fee6f3175d65b1c59cd15c8", + "co19_rev": "ae818220b12ec9c2470519db2c7167cbe4745e12", "co19_2_rev": "cf6eed0535e45413672bb5bb6e65df9f59846372", # The internal benchmarks to use. See go/dart-benchmarks-internal @@ -654,8 +654,6 @@ deps_os = { } } -# TODO(iposva): Move the necessary tools so that hooks can be run -# without the runtime being available. hooks = [ { "name": "firefox_jsshell",