Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayBufferView from TypedArray #12688

Closed
blois opened this issue Aug 23, 2013 · 6 comments
Closed

ArrayBufferView from TypedArray #12688

blois opened this issue Aug 23, 2013 · 6 comments
Assignees
Milestone

Comments

@blois
Copy link
Contributor

blois commented Aug 23, 2013

When running the html/xhr_test test, I'm seeing a warning in the console:

  ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead.

I converted the test from:
  xhr.send(data);
to:
  xhr.send(new Uint8List.view(data.buffer));

But still see the warning. What is the proper way to get an ArrayBufferView from a typed array?

@rakudrama
Copy link
Member

This could be a duplicate of Issue #10136.
Since VM typed arrays implement TypedData (ArrayBufferView) and ByteData (ArrayBuffer), a validation test of the form (if (x is ArrayBuffer) .... ) will trigger when it should not.

Fixing issue #10136 is getting more critical.


Marked this as being blocked by #10136.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2013

This looks like a problem in Dartium's XHR send:

http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp?revision=1350

We're not testing for ArrayBufferView at all. Given issue #10136, we should test for ArrayBufferView before we test for ArrayBuffer here.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2013

Taking a stab at this.


Set owner to @vsmenon.

@a-siva
Copy link
Contributor

a-siva commented Sep 18, 2013

Added this to the M7 milestone.

@vsmenon
Copy link
Member

vsmenon commented Sep 26, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@vsmenon
Copy link
Member

vsmenon commented Oct 18, 2013

Fixed here: https://codereview.chromium.org/22877041


Added Fixed label.

@blois blois added this to the M8 milestone Oct 18, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants