Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve linebreaking for imports #16366

Closed
pq opened this issue Jan 28, 2014 · 4 comments
Closed

Improve linebreaking for imports #16366

pq opened this issue Jan 28, 2014 · 4 comments
Assignees
@pq
Milestone
1.2

Comments

@pq
Copy link
Member

pq commented Jan 28, 2014

[user feedback]

The formatter break import stements in a way that is not usefull. How about deactivating it for imports?

import 'package:sdsadasd/ass/sadasdas/sadasdsad_asdasd_asdsada_adsasdasdsa.dart';

becomes:

import
    'package:sdsadasd/ass/sadasdas/sadasdsad_asdasd_asdsada_adsasdasdsa.dart';
@munificent
Copy link
Member

I'm in favor of this.

@pq
Copy link
Member Author

pq commented Jan 28, 2014

Me too.

As per our conversation, the current plan is to keep import directives and their URIs on one line and possible continue the as clause and show and hide combinators.

Changed the title to: "Improve linebreaking for imports".

@pq
Copy link
Member Author

pq commented Jan 28, 2014

Fixed w/ r32084.

Added Fixed label.

@pq pq self-assigned this Jan 28, 2014
@pq pq added this to the 1.2 milestone Jan 28, 2014
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#301.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
None yet
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@munificent @pq @DartBot