-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[barback] pub serve uses many file watcher on Mac OS #18141
Comments
Marked this as blocking #18087. |
As far as I know, calling |
If you read the title, you can see this is about the number of file watchers, not if they are recursive or not. You have e.g. not mentioned how many you expect it to create. This issue is about pub's usage of file watchers, not io's implementation. Reassigning to io makes no sense. Instead close it as WontFix, and I'll continue from there on. |
In the issue description, you explicitly call out recursive file watching as something pub should do. In any case, "pub serve" will call Added WontFix label. |
I'd like a little more context here. Anders, did you see pub using too many watchers on Mac? How many? What command were you running? What was the package you ran it on? WontFix isn't the right status here. Either there pub is using too many watchers in which case we should fix it, or it isn't, in which case this bug is just invalid. It's definitely not the case that we know pub uses a lot of watchers and are not deliberately fixing it. Added NeedsInfo label. |
As reported in issue #18087, running 'pub serve' uses up too many resources. See my comment here: https://code.google.com/p/dart/issues/detail?id=18087#c5. The current limit I found on my machines was in the range of ~100 (actually more, but let's assume this range). So, either 'pub serve' is using that many watchers, or the setup used when issue #18087 was seen, may have another issue. Currently, all our samples using transformers are unable to fetch packages: Package barback has no versions that match >=0.13.0-dev <0.13.0 derived from:
I'll look at this again, once our samples are fixed. |
(marking as owner for now, so I don't forget) Set owner to @Skabet. |
We haven't seen any complaints from other users matching those in issue #18087, nor does pub start anywhere near 100 watchers. You can verify this yourself by running "pub serve" in any package; whether the package uses transformers or not is irrelevant, so you can just avoid polymer packages until versioning is sorted out. Given that, I think we should proceed assuming there was something unique to Yegor's package that triggered the issue. |
These should be fixed now.
I'd still like to have more details here. As far as I know, you'd have to have a very pathologically strange package (like one with a hundred (!) path dependencies) to get that many watchers. That seems pretty unlikely, so maybe there is some other bug going on here. |
I see, and it makes a lot of sense if it's due to a special case package. What I noticed was the following: What steps will reproduce the problem? But maybe Yegor can shed some light on this. |
I'll close this, so we can move the discussion back to issue #18087. Added CannotReproduce label. |
This issue has been moved to dart-lang/pub#952. |
Mac is not very efficient with many file watchers (either they are hard-limited, or very slow to start when using more than ~100).
Given that Mac supports recursive file watching, that should be consider instead.
The text was updated successfully, but these errors were encountered: