Analyzer: implementing package spec proposal (.packages)

[sethladd]

Tracking issue for implementing the package spec proposal.

Main issue: dart-archive/dart_enhancement_proposals#5

Proposal: https://github.com/lrhn/dep-pkgspec/blob/master/DEP-pkgspec.md

[sethladd]

Marked this as blocking #23372.

[bwilkerson]

I'm guessing that this is for the command-line analyzer, and that the requirement is that it support a command-line option to specify a file? (If I understood correctly, we decided that analysis server would continue to run pub and that the command-line analyzer would run pub unless a package map file is specified.)

---

Added this to the 1.11 milestone.
Removed Priority-Unassigned label.
Added Priority-High, Analyzer-Command labels.

[sethladd]

For the workflow for how to find an app's dependencies, (including how to look for a packages/ dir, package spec file, package root, etc), please see the proposal and let us know if we need to refine that.

And yes, this is for the command-line analyzer.

[bwilkerson]

Set owner to @pq.

[sethladd]

Woohoo, thanks Phil!

[pq]

Added Started label.

[sethladd]

Marked this as blocking #22939.

[sethladd]

For the record, here's the plan that I recall from the meeting:

* analyzer and analysis server will try pub's list-package-dirs first.

• if that command returns with some signal that says "there's no pubspec.lock file here", then analyzer and analysis server will try the workflow as specified by the .packages proposal
• these tools will use the package_config package

Did I get that right?

[munificent]

That sounds right to me!

[sethladd]

So, the dartanalyzer works if you pass --packages path/to/.packages.

Next up: automatically find .packages

cc @pq

[sethladd]

Just tested a dartanalyzer from 1.12-dev.5.2

Auto-discovery worked!
I also renamed pubspec.lock and pubspec.yaml and auto-discovery still worked!
Passing in --packages to dartanalyzer worked!

What remains for this task?

cc @stereotype441 @bwilkerson

[sethladd]

Result from discussion:

• @stereotype441 will work to land a patch that makes sdk_ext + .packages work
• @sethladd and @devoncarew will turn on appveyor for analyzer_cli

cc @danrubel

[sethladd]

Howdy!

@stereotype441 and @pq how do we look here? Are you comfortable with the auto-discovery logic here?

[pq]

👍 I think we're good to go for this cut.

As discussed we have some integration tests to back-fill but that's a larger issue.