Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to add an option to enable assert + message support in analysis server #24276

Closed
sethladd opened this issue Sep 2, 2015 · 5 comments
Closed

Request to add an option to enable assert + message support in analysis server #24276

sethladd opened this issue Sep 2, 2015 · 5 comments
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone
1.50

Comments

@sethladd
Copy link
Contributor

sethladd commented Sep 2, 2015

Following on the work from #24217

We'd love a way for a user to opt-in to support for assert + message in Analysis server.

Thanks!
@sethladd sethladd added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server labels Sep 2, 2015
@munificent munificent mentioned this issue Sep 2, 2015
Closed
7 tasks
@bwilkerson
Copy link
Member

One possible approach for this would be to add the flag via the .analysis_options file.

@stereotype441 stereotype441 self-assigned this Sep 2, 2015
@sethladd
Copy link
Contributor Author

sethladd commented Sep 2, 2015

I'm a fan.

@stereotype441
Copy link
Member

Note: FixProcessor._inferUndefinedExpressionType will need to be modified so that fixes like "create local variable" will infer the correct type for the assertion expression.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed Priority-Medium labels Mar 1, 2016
@stereotype441 stereotype441 removed their assignment Aug 15, 2016
@dgrove dgrove added this to the 1.50 milestone Oct 20, 2016
@bwilkerson
Copy link
Member

Messages in asserts is now enabled by default in analyzer (https://codereview.chromium.org/2557513008/).

@sethladd
Copy link
Contributor Author

sethladd commented Dec 8, 2016

Thanks for the update!

@sethladd sethladd mentioned this issue Dec 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.50
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @stereotype441 @dgrove @bwilkerson