-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart:html interfaces which should be Lists #2713
Comments
This comment was originally written by @seaneagan A couple more: DomPluginArray |
This comment was originally written by @seaneagan a few more: SpeechRecognitionResult |
Issue #2972 has been merged into this issue. |
This comment was originally written by imjason...@gmail.com Some of these seem like they may be easy to fix (e.g., FileList -> List<File>) If someone's willing to shepherd me through the process, I'd be happy to try sending patches for some of these. |
cc @jacob314. |
Hi Jason, We have a contributing guide at http://code.google.com/p/dart/wiki/Contributing and a helpful blog post here: http://phylotic.blogspot.com/2012/05/im-contributor-and-so-can-you.html Be sure to sign the http://code.google.com/legal/individual-cla-v1.0.html which is a super simple online form. Once you have that signed and the project checked out, we can help you with next steps. Let's move the conversation to the mailing list (https://groups.google.com/a/dartlang.org/forum/#!forum/misc) for further discussion. Thanks! |
cc @vsmenon. |
I was just bitten by this too (in my case, CSSRuleList). |
Added this to the M1 milestone. |
Fixed in revision 12939. Added Fixed label. |
A little more information on this bug. All of the interfaces that behave exactly like lists were converted to List<Foo> and the FooList type was removed. For types that behave like lists but have other methods, we keep the FooList type, but they implement List. |
Marked this as blocking #5499. |
Thanks! |
Awesome! |
Issue #2174 has been merged into this issue. |
This comment was originally written by @seaneagan Since dart:html is being looked at heavily now, just wanted to mention that there are still quite a few which either: * don't implement List
dart:html DataTransferItemList dart:svg LengthList |
This issue was originally filed by @seaneagan
The following dart:html interfaces could either be replaced by or at least extend List:
AnimationList
ClientRectList
CSSRuleList
CSSValueList
DataTransferItemList
DOMMimeTypeArray
DOMSettableTokenList
DOMTokenList
FileList
FilteredElementList
HTMLCollection
HTMLAllCollection
HTMLOptionsCollection
MediaStreamList
MediaStreamTrack
MediaStreamTrackList
SpeechGrammarList
SpeechInputResultList
SpeechRecognitionResultList
SQLResultSetRowList
StyleSheetList
SVGAnimatedLengthList
SVGAnimatedNumberList
SVGAnimatedTransformList
SVGElementInstanceList
SVGLengthList
SVGNumberList
SVGPathSegList
SVGPointList
SVGStringList
TextTrackCueList
TextTrackList
TimeRanges
TouchList
Many of them are immutable, in which cases extending an immutable version of List (issue #236) would be optimal.
The text was updated successfully, but these errors were encountered: