Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement assert() messages in dev_compiler #27342

Closed
jmesserly opened this issue Sep 14, 2016 · 7 comments
Closed

Implement assert() messages in dev_compiler #27342

jmesserly opened this issue Sep 14, 2016 · 7 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug web-dev-compiler
Milestone

Comments

@jmesserly
Copy link

From @vsmenon on August 26, 2015 21:38

This adds optional messages to an assert.

See DEP: https://github.com/sethladd/dep_assert_with_optional_message/blob/master/proposal.md

Main bug: #24213

Copied from original issue: dart-archive/dev_compiler#303

@jmesserly jmesserly added web-dev-compiler type-enhancement A request for a change that isn't a bug labels Sep 14, 2016
@jmesserly
Copy link
Author

behind a flag? Aren't we entirely behind a flag? ;)

@jmesserly
Copy link
Author

(experimental language flags to an experimental compiler, we must go deeper :) )

edit: in seriousness though, I think analyzer's flag will protect us, since they're the ones doing the parsing.

@jmesserly
Copy link
Author

oh shoot, i realized we're blocked on analyzer: #24217

@vsmenon
Copy link
Member

vsmenon commented Oct 20, 2016

@bwilkerson can you assign this back to me when #24217 is closed? The DDC part should be really easy.

@floitschG floitschG changed the title Implement assert() messages behind a flag Implement assert() messages Oct 24, 2016
@dgrove
Copy link
Contributor

dgrove commented Nov 21, 2016

@lrhn Can you provide an update?

@lrhn
Copy link
Member

lrhn commented Nov 22, 2016

As far as I can see, it's implemented in dart2js and the analyzer behind flags.
I have an old CL for the VM, but it hasn't aged gracefully, so I'm working on a rewrite.

@munificent munificent assigned munificent and unassigned bwilkerson Dec 12, 2016
@munificent munificent changed the title Implement assert() messages Implement assert() messages in dev_compiler Dec 12, 2016
@munificent
Copy link
Member

I'll take on the DDC side of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug web-dev-compiler
Projects
None yet
Development

No branches or pull requests

7 participants