Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to run co19_2 test suite on Dart 2.0 configurations #33484

Closed
Tracked by #12
mkustermann opened this issue Jun 18, 2018 · 3 comments
Closed
Tracked by #12

We need to run co19_2 test suite on Dart 2.0 configurations #33484

mkustermann opened this issue Jun 18, 2018 · 3 comments
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@mkustermann
Copy link
Member

mkustermann commented Jun 18, 2018 •
edited
Loading

We really should test co19 on Dart 2.0 configurations. It appears like we don't run co19 on e.g. the --compiler=dartkp --strong configuration - probably we also don't run it on many other configurations.

Just today I've been fixing an issue, which does have a test in co19 but we don't run seem to run it, so the issue was not uncovered.

The necessary changes are:

@athomas Could you take a look at this?

/cc @mraleph @a-siva
@anders-sandholm anders-sandholm added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Jun 21, 2018
@JekCharlsonYu JekCharlsonYu mentioned this issue Aug 16, 2018
Closed
23 tasks
@athomas
Copy link
Member

athomas commented Aug 27, 2018

Current status:
co19_2 is enabled for frontend and analyzer builders.
dart2js is going to get it in the next roll (ETA: this week).
VM is next in line.

@athomas
Copy link
Member

athomas commented Oct 5, 2018 •
edited
Loading

Current status:
dart2js/analyzer/frontend are using co19_2 on all builders
VM CQ builders (vm-kernel-linux-product-x64, vm-kernel-linux-release-simdbc64, vm-kernel-linux-release-x64) are enabled.

Next step is to add some vm-kernel-precomp builders.

@athomas
Copy link
Member

athomas commented Oct 29, 2020

There are quite a few AOT builders running co19 tests now.

@athomas athomas closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anders-sandholm @mkustermann @athomas