Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary type argument count in functions in dart2js #33819

Open
nickclmb opened this issue Jul 11, 2018 · 4 comments
Open

Support arbitrary type argument count in functions in dart2js #33819

nickclmb opened this issue Jul 11, 2018 · 4 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js

Comments

@nickclmb
Copy link

nickclmb commented Jul 11, 2018

Hi all,

Dart2js crashes with error because of this unimplemented TODO:
https://github.com/dart-lang/sdk/blob/master/pkg/compiler/lib/src/ssa/builder_kernel.dart#L4387

Seems like critical for us, can you please check?

The compiler crashed: Internal Error: Generic function instantiation not implemented for 8 type arguments
#0      CompilerDiagnosticReporter.internalError (file:///tmp/tmpAi0tzS/dart-2.0.0-dev.67.0/dart/pkg/compiler/lib/src/compiler.dart:868:5)
#1      KernelSsaGraphBuilder.visitInstantiation (file:///tmp/tmpAi0tzS/dart-2.0.0-dev.67.0/dart/pkg/compiler/lib/src/ssa/builder_kernel.dart:4375:16)
#2      Instantiation.accept (package:kernel/ast.dart:2959:36)
@nickclmb
Copy link
Author

@nickclmb
Copy link
Author

@kevmoo @johnniwinther

@sigmundch
Copy link
Member

Because the full solution will take us longer to implement, we are landing first a change to raise the limit manually. We should be able to support up to 20 type arguments after the change lands. Our hope is that this will unblock you until we have the full solution ready.

CL from @johnniwinther is here https://dart-review.googlesource.com/c/sdk/+/65541

@nickclmb
Copy link
Author

Thanks for update and your work. 20 should be enough, so far we have 9 generics max. Looking forward for hotfix. Thanks in advance

@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants