Implementation Issue for SuperMixins: Analyzer

[JekCharlsonYu]

What: Issue for implementation for Analyzer

ETA: 10/15 in Dart Repo.

For: SuperMixins Implementation and strawman documentation

Meta Issue: This is subsumed under the Super Mixins Meta Issue in the Language Repo

Analyzer Tasks

• Add the AST nodes required to represent the new mixin syntax
• Add support to AstBuilder to build the AST (dependent on the fasta parser work) - @danrubel
  • Add parser recovery for mixin header similar to class header - @danrubel
• Add support to the element model to represent the semantics of mixins - @bwilkerson
• Add support for the new mixins to summary files - @scheglov
• Add support for resolving the new mixin syntax - @scheglov
• Add support for building the new mixin element model - @scheglov
• Add error checking related to the new mixin semantics (mostly done)

Analysis Server Tasks

• Add indexing/search support - @scheglov
• Add code completion support
  • keyword completion - @bwilkerson
  • completion in on clause - @bwilkerson
  • new mixins should not be suggested in extends clauses - @bwilkerson
  • new mixins should not be suggested in instance creations
• Add folding support - @bwilkerson
• Add outline support - @bwilkerson
• Add syntax highlighting support - @bwilkerson
• Add hover support - @bwilkerson
• Add quick fixes for new errors - @scheglov
• Add a quick assist to convert existing classes to the new syntax (when appropriate)
  • Initially available at declaration sites - @bwilkerson
  • Eventually available at use sites as well - @danrubel

[danrubel]

Parsing, events, parse errors, recovery, and AstBuilder mods are now complete.

[leafpetersen]

Do we have an estimate on when error checking will land?

[bwilkerson]

Error checking has started to land, but is not yet complete.

[leafpetersen]

CL out here with mixin inference tests: https://dart-review.googlesource.com/c/sdk/+/74017

[leafpetersen]

Inference tests have landed. cc @scheglov

mixin_declaration/mixin_declaration_inference_valid_classes_test: CompileTimeError # #34164

[bwilkerson]

I created #34661 to capture the rest of the rest of the work on the quick assist. There are many errors that need quick fixes besides the new ones added for this feature, so I didn't create an issue for those.

Those are both nice to haves, so I'm marking this as done.

[DanTup]

@bwilkerson There's a tick above next to "keyword completion" - is this expected to be in master? I don't see it using yesterdays nightly build (2.2.0-edge.f6c41ac3bc4ca689de745588c282425c9adf8262):

I do get it for other keywords (for ex abstract).

[bwilkerson]

Yes, I would have expected that to have been on master. I'm seeing the same behavior from the latest analyzer branch, so it appears to be a regression.