Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Issue for Super Mixins: DDC #34167

Closed
Tracked by #12
JekCharlsonYu opened this issue Aug 16, 2018 · 4 comments
Closed
Tracked by #12

Implementation Issue for Super Mixins: DDC #34167

JekCharlsonYu opened this issue Aug 16, 2018 · 4 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Milestone

Comments

@JekCharlsonYu
Copy link
Contributor

JekCharlsonYu commented Aug 16, 2018

What: Issue for implementation for DDC

ETA: 10/15 in Dart Repo.

For: SuperMixins Implementation and strawman documentation

Meta Issue: This is subsumed under the Super Mixins Meta Issue in the Language Repo

Comments: Feel free to break this further into further tasks and issues, or use as a meta issue for all the tasks in the implementation plan

Note: This is a P1 for Super Mixins

@JekCharlsonYu JekCharlsonYu added the P2 A bug or feature request we're likely to work on label Aug 16, 2018
@JekCharlsonYu JekCharlsonYu added this to the Dart2.1 milestone Aug 16, 2018
@JekCharlsonYu JekCharlsonYu added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Aug 16, 2018
@vsmenon vsmenon assigned jmesserly and unassigned vsmenon Aug 21, 2018
@jmesserly
Copy link

jmesserly commented Sep 14, 2018

testing CL now: https://dart-review.googlesource.com/c/sdk/+/74965

DDC+Kernel support is not implemented yet because we can't tell which classes are these new mixins.

@leafpetersen
Copy link
Member

I landed inference tests, and I'm seeing some tests that are expected to produce a compile time error and which are passing on the analyzer, failing on ddc. This seems unexpected so re-opening this for investigation.

mixin_declaration/mixin_declaration_inference_invalid_03_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_04_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_05_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_06_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_07_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_08_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_09_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167
mixin_declaration/mixin_declaration_inference_invalid_10_test: MissingCompileTimeError   # https://github.com/dart-lang/sdk/issues/34167

@leafpetersen leafpetersen reopened this Sep 18, 2018
@jmesserly
Copy link

I'm going to open a new issue, since this one is about implementing the feature in DDC, which has been landed.

I don't see how inference/MissingCompileTimeError can be a DDC problem (we don't do inference, or produce compile errors, except in rare circumstances), but I'll take a look. It could be something related to Analyzer task model or summaries, both of which DDC uses, and Analyzer tests don't.

@jmesserly
Copy link

new bug is #34516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Development

No branches or pull requests

4 participants