Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change] Discontinue deprecated core library APIs, part I #34233

Closed
6 tasks done
natebosch opened this issue Aug 22, 2018 · 4 comments
Closed
6 tasks done

[breaking change] Discontinue deprecated core library APIs, part I #34233

natebosch opened this issue Aug 22, 2018 · 4 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. enhancement-breaking-change An enhancement which is breaking. type-enhancement A request for a change that isn't a bug

Comments

@natebosch
Copy link
Member

natebosch commented Aug 22, 2018

The following Dart core library APIs, which are all currently deprecated, are now being fully removed.

This issue tracks APIs to be discontinued prior to Dart 3.0. Issue #49529 tracks further APIs that will be discontinued in Dart 3.0.

Phase one (pre 3.0)

The following APIs are being removed prior to 3.0, as they are no longer functional and thus their removal is expected to have minimal effect.

dart:convert

CL: https://dart-review.googlesource.com/c/sdk/+/247741

dart:mirrors

The following are removed in Dart 2.19; they were experimental / only used internally in Dart2js (#32507):

CL : https://dart-review.googlesource.com/c/sdk/+/248003

dart:io

The following are removed in Dart 2.18:

CLs: https://dart-review.googlesource.com/c/sdk/+/235701, https://dart-review.googlesource.com/c/sdk/+/246962

dart:developer

The following are removed in Dart 2.19:

  • kInvalidParams, kExtensionError, kExtensionErrorMax, and kExtensionErrorMin in ServiceExtensionResponse (use invalidParams, extensionError, extensionErrorMax, and extensionErrorMin)

CL: https://dart-review.googlesource.com/c/sdk/+/251767

The following will be deprecated in Dart 2.19, and then removed in Dart 3.0:

Phase II, Dart 3.0

See list in #49529

@natebosch natebosch changed the title @proxy was deprecated but never removed Decide when and how to remove things that were deprecated in the SDK Aug 22, 2018
@dgrove dgrove added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Aug 23, 2018
@lrhn
Copy link
Member

lrhn commented Aug 24, 2018

Most of these are intentionally left in for Dart 2 (I think DeferredLibrary was the only one we believed we could remove, we just didn't want to take a chance late in the process).

I would want to remove them in Dart 3.0 (or when they have been deprecate for at least some amount of time, like six months, but Dart 3.0 probably won't happen before that).

@natebosch
Copy link
Member Author

Another thing we should consider deprecating soon and then deleting for Dart 3.0 is dart:web_sql

For a long time the doc has said not to use it - why continue to publish it?

@lrhn lrhn added enhancement-breaking-change An enhancement which is breaking. type-enhancement A request for a change that isn't a bug labels Oct 2, 2020
@mit-mit mit-mit changed the title Decide when and how to remove things that were deprecated in the SDK Discontinue deprecated core library APIs Jun 11, 2022
@mit-mit
Copy link
Member

mit-mit commented Jun 11, 2022

Another thing we should consider deprecating soon and then deleting for Dart 3.0 is dart:web_sql

This was removed a little while back.

@mit-mit mit-mit changed the title Discontinue deprecated core library APIs [breaking change] Discontinue deprecated core library APIs Jun 20, 2022
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
Contributes to bug: #34233

Change-Id: I18f12b8c8da2ec444911128b96111e93df6c0496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251767
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
copybara-service bot pushed a commit that referenced this issue Jul 20, 2022
Contributes to bug: #34233
Fixes #32507

Change-Id: Iee72e9f91fc1fc49761e6f5e6e9dba412493c8ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248003
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
@mit-mit mit-mit changed the title [breaking change] Discontinue deprecated core library APIs [breaking change] Discontinue deprecated core library APIs, part I Jul 26, 2022
@jakemac53
Copy link
Contributor

If possible it would be good if we could analyze pub.dev for usages of these apis before removing them, there is a thread on the dart-lang gitter because somebody got broken by a usage of MirrorsUsed in package:mustache. I filed an issue for them to drop the usage, but it would be better if we could do that prior to actually removing the APIs.

copybara-service bot pushed a commit that referenced this issue Aug 9, 2022
Contributes to bug: #34233

Change-Id: I443fa14342680b61bf7357d40347427200fea29b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247741
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
@mit-mit mit-mit closed this as completed Aug 9, 2022
@mit-mit mit-mit added this to the August Release (Dart 2.18) milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. enhancement-breaking-change An enhancement which is breaking. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants