Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dartdoc for Flutter supports the new mixin syntax #34642

Closed
yjbanov opened this issue Oct 2, 2018 · 6 comments
Closed

Make sure dartdoc for Flutter supports the new mixin syntax #34642

yjbanov opened this issue Oct 2, 2018 · 6 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@yjbanov
Copy link

yjbanov commented Oct 2, 2018

I'm filing this issue proactively. I haven't gotten far enough to verify if this already works or not. However, practice shows that something like this is extremely unlikely to work by accident. If we know that this doesn't work yet, we need to make sure someone starts working on it asap.

If this is already done, feel free to just close the issue.

@JekCharlsonYu @jcollins-g @vsmenon

@yjbanov yjbanov added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 2, 2018
@yjbanov yjbanov added this to the Dart2.1 milestone Oct 2, 2018
@jcollins-g
Copy link
Contributor

This is already implemented in dart-lang/dartdoc#1765 and is blocked on an analyzer publish, which has some ecosystem impacts we're trying to work through.

It is tracked here: dart-lang/dartdoc#1752 and here: dart-lang/language#12

@yjbanov yjbanov changed the title Make sure dartdoc tools support the new mixin syntax Make sure dartdoc for Flutter supports the new mixin syntax Oct 2, 2018
@yjbanov
Copy link
Author

yjbanov commented Oct 2, 2018

Cool. I'll keep this issue open. I changed the title to reflect that this is for Flutter specifically. Whatever analyzer/ecosystem issues that need to be resolved, should be resolved before we can consider this issue as fixed.

Unless the remaining issues are non-blocking?

@yjbanov yjbanov reopened this Oct 2, 2018
@jcollins-g
Copy link
Contributor

I would still prefer to track this in dart-lang/dartdoc#1752 as that issue is linked to the larger tracking issue, but if having this issue helps in some way you can leave this open.

@yjbanov
Copy link
Author

yjbanov commented Oct 3, 2018

Only because we've been tracking everything blocking the roll out of the new mixins into Flutter under Dart2.1 milestone here.

@dgrove
Copy link
Contributor

dgrove commented Oct 9, 2018

dart-lang/dartdoc#1752 is closed. @jcollins-g can this be closed?

@jcollins-g
Copy link
Contributor

I believe so -- some support definitely exists and there are no blockers I know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants