Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperNegativeTest doesn't match current spec #358

Closed
DartBot opened this issue Nov 6, 2011 · 3 comments
Closed

SuperNegativeTest doesn't match current spec #358

DartBot opened this issue Nov 6, 2011 · 3 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@DartBot
Copy link

DartBot commented Nov 6, 2011

This issue was originally filed by jimhug@google.com


It looks like all three implementations (dartc, vm and frog) currently fail on this test, and the spec says:
  "If no superinitializer is provided, an implicit superinitializer of the form super() is added at the end of k’s initializer list, unless the enclosing class is class Object."

This was reported as Bug 4400118, but I wanted to get this into the public system and hopefully get this resolved quickly as an obvious test bug. I don't know if there is a test for the correct insertion of the missing super call - but this test could be usefully converted to do that with a little extra verification that A's constructor is actually called when creating a new B.

@DartBot
Copy link
Author

DartBot commented Nov 8, 2011

This comment was originally written by drfibonacci@google.com


Added Area-Frog, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Nov 9, 2011

This comment was originally written by @mhausner


SuperNegativeTest is indeed obsolete. Dart specifies that an implicit call to super() is added to the initializer list if no explicit super call is present.

We have Constructor4Test to check that implicit super calls are added, so I think the best is to eliminate SuperNegativeTest. I'll do that.


Set owner to @mhausner.

@DartBot
Copy link
Author

DartBot commented Nov 9, 2011

This comment was originally written by @mhausner


Test removed.


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

1 participant