Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set.add should return boolean #4210

Closed
DartBot opened this issue Jul 26, 2012 · 2 comments
Closed

Set.add should return boolean #4210

DartBot opened this issue Jul 26, 2012 · 2 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented Jul 26, 2012

This issue was originally filed by domi...@google.com

Set.remove returns a boolean indicating if the value was in the set. Set.add should do the same. This would allow code to try to add something and then only do something expensive if this resulted in a new addition to the set.
@DartBot
Copy link
Author

DartBot commented Jul 26, 2012

This comment was originally written by @seaneagan

dupe of issue #3546

@dgrove
Copy link
Contributor

dgrove commented Jul 27, 2012

Added Duplicate label.
Marked as being merged into #3546.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report labels Jul 27, 2012
@dgrove dgrove mentioned this issue Jun 3, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrove @DartBot