Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js: doesn't report expected compile-time errors #5519

Closed
peter-ahe-google opened this issue Sep 27, 2012 · 20 comments
Closed

dart2js: doesn't report expected compile-time errors #5519

peter-ahe-google opened this issue Sep 27, 2012 · 20 comments
Assignees

Comments

@peter-ahe-google
Copy link
Contributor

The following tests are failing after changing test.dart to distinguish between compile-time and runtime errors:

co19/Language/11_Statements/14_Throw_A03_t01: fail
co19/Language/13_Libraries_and_Scripts/4_Scripts_A03_t01: fail
co19/Language/13_Libraries_and_Scripts/4_Scripts_A03_t03: fail

language/bad_constructor_test/04: fail
language/bad_constructor_test/05: fail
language/bad_constructor_test/06: fail
language/constructor_named_arguments_test/01: fail
language/external_test/10: fail
language/getter_no_setter2_test/01: fail
language/getter_no_setter_test/01: fail
language/illegal_invocation_test/03: fail
language/isnot_malformed_type_test/01: fail
language/new_expression_type_args_test/01: fail
language/not_enough_positional_arguments_test/01: fail
language/not_enough_positional_arguments_test/02: fail
language/optional_named_parameters_test/01: fail
language/optional_named_parameters_test/03: fail
language/optional_named_parameters_test/05: fail
language/optional_named_parameters_test/07: fail
language/optional_named_parameters_test/09: fail
language/setter_no_getter_call_test/01: fail
language/setter_no_getter_test/01: fail

I suspect some of these tests are incorrect (due to relaxed semantics in Dart Programming Language Specification 0.11).

More investigation is needed.

@kasperl
Copy link

kasperl commented Sep 28, 2012

Added this to the Later milestone.

@peter-ahe-google
Copy link
Contributor Author

Karl, it would be great if you could investigate these.


Set owner to @karlklose.

@peter-ahe-google
Copy link
Contributor Author

All references to this bug has been "triaged" away.


Set owner to @peter-ahe-google.
Added Fixed label.

@peter-ahe-google
Copy link
Contributor Author

This bug is still referenced from language_dart2js.status.


Added Triaged label.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M2 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@sgjesse
Copy link
Contributor

sgjesse commented Aug 26, 2013

Test

language/new_expression_type_args_test/00

is also failing.

@sgjesse
Copy link
Contributor

sgjesse commented Aug 26, 2013

Checked the language/language_dart2js.status, and currently the following tests are referring to this issue:

For dart2js:
new_expression_type_args_test/00
new_expression_type_args_test/01
constructor_named_arguments_test/01
getter_no_setter_test/01
not_enough_positional_arguments_test/01

For dart2dart:
compile_time_constant10_test/01
compile_time_constant10_test/02
compile_time_constant_arguments_test/01
compile_time_constant_arguments_test/02
compile_time_constant_arguments_test/03
compile_time_constant_arguments_test/05
compile_time_constant_arguments_test/06
const_constructor_syntax_test/04
const_syntax_test/01
const_syntax_test/02
const_syntax_test/03
const_syntax_test/04
const_syntax_test/05
const_syntax_test/06
const_syntax_test/07
const_syntax_test/08
const_syntax_test/10
constructor_named_arguments_test/01
final_syntax_test/01
final_syntax_test/02
final_syntax_test/03
final_syntax_test/04
getter_no_setter_test/01
named_parameters_aggregated_test/01
named_parameters_aggregated_test/03
not_enough_positional_arguments_test/01

@sgjesse
Copy link
Contributor

sgjesse commented Aug 28, 2013

With recent updates (4 moved to separate issue numbers) this is now down to:

For dart2js:
new_expression_type_args_test/00
new_expression_type_args_test/01
constructor_named_arguments_test/01
getter_no_setter_test/01

For dart2dart:
compile_time_constant10_test/01
compile_time_constant10_test/02
compile_time_constant_arguments_test/01
compile_time_constant_arguments_test/02
compile_time_constant_arguments_test/03
compile_time_constant_arguments_test/05
compile_time_constant_arguments_test/06
const_constructor_syntax_test/04
const_syntax_test/01
const_syntax_test/02
const_syntax_test/03
const_syntax_test/04
const_syntax_test/05
const_syntax_test/06
const_syntax_test/07
const_syntax_test/08
const_syntax_test/10
constructor_named_arguments_test/01
final_syntax_test/01
final_syntax_test/02
final_syntax_test/03
final_syntax_test/04
getter_no_setter_test/01

@peter-ahe-google
Copy link
Contributor Author

Removed Priority-Medium label.
Added Priority-High label.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #5825.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #5852.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #11346.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #11174.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #6708.

@peter-ahe-google
Copy link
Contributor Author

Marked this as being blocked by #7284.

@sigmundch
Copy link
Member

seems that all these has been fixed except one case, where we are reporting an error that is too strong. I'm closing this bug and created #25225 to track that.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants