Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAP] --pause-isolates-on-start flag is not respected for web refreshes #55860

Closed
elliette opened this issue May 28, 2024 · 1 comment · Fixed by dart-lang/webdev#2441
Closed

[DAP] --pause-isolates-on-start flag is not respected for web refreshes #55860

elliette opened this issue May 28, 2024 · 1 comment · Fixed by dart-lang/webdev#2441
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation pkg-dds For issues related to the Dart Development Service

Comments

@elliette
Copy link
Contributor

Unlike VM apps, web apps can both be hot-restarted and restarted via a page-refresh. When they are restarted with a page refresh, the readyToResume request is never sent after the breakpoints are set, and so if --pause-isolates-on-start is set, the app never gets resumed.

FYI @DanTup - I have a fix prepared that I will send out shortly.
@elliette elliette added the dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation label May 28, 2024
@DanTup DanTup added the pkg-dds For issues related to the Dart Development Service label May 28, 2024
@elliette
Copy link
Contributor Author

This is also occurring on a hot-restart request

@srawlins srawlins added the area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. label May 29, 2024
@elliette elliette mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation pkg-dds For issues related to the Dart Development Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send a kPausePostRequest after restarting to notify clients to resume elliette/webdev
3 participants
@srawlins @DanTup @elliette