default quick fixes for omit_obvious_local_variable_types

[devoncarew]

When trying to quick fix analysis issues from omit_obvious_local_variable_types, I see different defaults that the quick fixes for omit_local_variable_types. omit_obvious_local_variable_types will default to adding an ignore for an issue; omit_local_variable_types will default to replacing the type declaration with var.

omit_local_variable_types (preferred):

omit_obvious_local_variable_types (less desired):

cc @eernstg

(discussion issue at #58773)

[bwilkerson]

The items under "More Actions..." are probably assists, rather than fixes. Server will not produce an assist if it's already been suggested as a fix, so the placement of "Replace type annotation with 'var'" (and the absence of the "everywhere in file" variant) is a result of the fix not being associated with the diagnostic.

The presence of "Remove type annotation" seems like a bug. It's doing exactly the same as "Replace type annotation with 'var'" and there's no value in having both appear.

[devoncarew]

... is a result of the fix not being associated with the diagnostic

Thanks Brian! That explanation seems to match the behavior I'm seeing.

[eernstg]

Surely, omit_obvious_local_variable_types should give rise to the same quick fixes and assists as omit_local_variable_types — they are flagging any given location for exactly the same reasons, the only difference is that omit_local_variable_types will flag a larger number of locations than omit_obvious_local_variable_types.

Created https://dart-review.googlesource.com/c/sdk/+/376320 for this.

[FMorschel]

@eernstg, the CL has been merged. Can this be closed?