Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark dartExecutable parameter as required in DartDevelopmentServiceLauncher.start #56565

Open
bkonyi opened this issue Aug 23, 2024 · 1 comment
Open

Mark dartExecutable parameter as required in DartDevelopmentServiceLauncher.start #56565

bkonyi opened this issue Aug 23, 2024 · 1 comment
Assignees
@bkonyi
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P2 A bug or feature request we're likely to work on pkg-dds For issues related to the Dart Development Service triaged Issue has been triaged by sub team

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Aug 23, 2024

This will require the path to the Dart executable to be explicitly provided rather than falling back to using Platform.executable which may not work in all contexts.
@bkonyi bkonyi added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P2 A bug or feature request we're likely to work on pkg-dds For issues related to the Dart Development Service triaged Issue has been triaged by sub team labels Aug 23, 2024
@bkonyi bkonyi self-assigned this Aug 23, 2024
@bkonyi
Copy link
Contributor Author

bkonyi commented Aug 23, 2024

This is technically a breaking change to package:dds, so we'll need to do a major version bump when we make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P2 A bug or feature request we're likely to work on pkg-dds For issues related to the Dart Development Service triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkonyi