Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart analyze should not spawn analyzer_plugins #56667

Open
rrousselGit opened this issue Sep 8, 2024 · 2 comments
Open

dart analyze should not spawn analyzer_plugins #56667

rrousselGit opened this issue Sep 8, 2024 · 2 comments
Labels
analyzer-plugin area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@rrousselGit
Copy link

For a long time, analyzer_plugins never quite worked with dart analyze / flutter analyze (cf flutter/flutter#28327).
Yet those command still somehow try to spawn analyzer_plugins regardless

Most analyzer_plugins already offer a custom CLI to manually trigger a dart analyze equivalent for their plugins. So since analyzer_plugins don't work with dart analyze yet, it's probably more logical to not run them at all, and suggest analyzer_plugin authors to make a custom CLI for it.
@dart-github-bot
Copy link
Collaborator

Summary: The dart analyze command currently attempts to spawn analyzer plugins, even though they don't function correctly with it. This behavior is unnecessary and confusing, as plugins already provide their own CLIs for analysis. It's suggested to remove plugin spawning from dart analyze to avoid misleading users.

@dart-github-bot dart-github-bot added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Sep 8, 2024
@rrousselGit rrousselGit mentioned this issue Sep 8, 2024
Open
@lrhn lrhn removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Sep 8, 2024
@pq
Copy link
Member

pq commented Sep 9, 2024

@srawlins

@pq pq added analyzer-plugin P2 A bug or feature request we're likely to work on labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-plugin area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @lrhn @rrousselGit @dart-github-bot